Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LLM Provider interface and Gemini module #944

Merged
merged 24 commits into from
Dec 23, 2024
Merged

Add LLM Provider interface and Gemini module #944

merged 24 commits into from
Dec 23, 2024

Conversation

sydp
Copy link
Collaborator

@sydp sydp commented Dec 19, 2024 •
edited
Loading

Adds:

  • an interface/manager for LLM Providers
  • a Gemini provider module
  • a VertexAI provider module
  • a Ollama provider module
  • updates /data/config.json with example configs for LLM providers
  • refactor of LLMProcessorBase

@sydp sydp marked this pull request as ready for review December 19, 2024 23:29
@sydp sydp requested a review from ramo-j December 20, 2024 06:54
@sydp
Copy link
Collaborator Author

sydp commented Dec 20, 2024

Removed some modules to keep the PR to a managable size and will send these separately.

@sydp sydp changed the title Add LLM Provider interface and modules Add LLM Provider interface and Gemini module Dec 20, 2024
ramo-j
ramo-j previously approved these changes Dec 22, 2024
View reviewed changes
Copy link
Collaborator

@ramo-j ramo-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of small nits.

dftimewolf/lib/processors/llm_base.py Outdated Show resolved Hide resolved
dftimewolf/lib/processors/llmproviders/gemini.py Outdated Show resolved Hide resolved
@sydp sydp requested a review from ramo-j December 23, 2024 00:59
@sydp sydp merged commit 3fd5684 into log2timeline:main Dec 23, 2024
9 checks passed
@sydp sydp mentioned this pull request Dec 23, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramo-j ramo-j ramo-j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydp @ramo-j