Remove method from interface ILayer and update all places accordingly

[sschulz92]

Within this PR I removed isType() from interface ILayer.java which is deprecated. I updated all remaining places accordingly :)

"New" way to go: hasResource()

[fgdrf]

I had a look at the Implementations of ILayer and isType and hasResource were not implemented the same way:

WMSLaser:

udig-platform/plugins/org.locationtech.udig.info.tests/src/org/locationtech/udig/info/tests/WMSLayer.java

Lines 229 to 235 in 4468dd6

	public <T> boolean isType(Class<T> resourceType) {
	if (resourceType == Layer.class) {
	return true;
	}
	return false;
	}

udig-platform/plugins/org.locationtech.udig.info.tests/src/org/locationtech/udig/info/tests/WMSLayer.java

Lines 274 to 277 in 4468dd6

	@Override
	public <T> boolean hasResource(Class<T> resourceType) {
	return false;
	}

whereas layerImpl is fine in my option:

udig-platform/plugins/org.locationtech.udig.project/src/org/locationtech/udig/project/internal/impl/LayerImpl.java

Lines 992 to 1008 in bfd630e

	/**
	* @deprecated
	*/
	@Deprecated
	@Override
	public <T> boolean isType(Class<T> resourceType) {
	return hasResource(resourceType);
	}
	@Override
	public <T> boolean hasResource(Class<T> resourceType) {
	for (IGeoResource resource : getGeoResources()) {
	if (resource.canResolve(resourceType))
	return true;
	}
	return false;
	}

and LayerDecorator just delegates to the wrapped Layer which is fine to.

So I guess we at least WMSLayer should be adapted and I'd prefer to add a hint to release-notes for 2.3 as well (https://github.com/locationtech/udig-platform/blob/dca5ae79fdf5f90f343e80ef10c627e03b7cb076/docs/user/en/what_is_new/What%20is%20new%202.3.rst)

[fgdrf]

as stated in previous comment, at least WMSLayer might raise some issues because implementations of isType and hasResource aret different.

[fgdrf]

wondering what would happen here, since WMSLayer.hasResource() is always false whereas isType was true ..

[sschulz92]

Basically WMSLayer.java is located into the module "org.locationtech.udig.info.tests" - so it's a test class. Does it really that matter? From my perspective we may even think about removing this class (should not belong to a test bundle).