-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce LoggingSupport #585
base: master
Are you sure you want to change the base?
Conversation
@sschulz92 @ybnkv @olsmn What do you think about this aproach? Throwables are logged as warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this is a good approach I think :)
plugins/org.locationtech.udig.core/src/org/locationtech/udig/core/internal/CorePlugin.java
Outdated
Show resolved
Hide resolved
...ntech.udig.info/src/org/locationtech/udig/tool/info/internal/display/BrowserInfoDisplay.java
Show resolved
Hide resolved
46ee20f
to
579f55f
Compare
I'm going to add few lines to release-notes and I guess I've to grep through documentations:
since ID is not necessary anymore for logging because of usage Plugin.getBundle().getSymbolicName() in LoggingSupport. |
potential candidats (RST) to update to LoggingSupport:
|
31d803e
to
60c7049
Compare
to have a common way to log messages overall modules. Reduces code-duplications as well, if deprecated methods are removed in the future Signed-off-by: Frank Gasdorf <[email protected]>
Change-Id: I0b078706af6cdd32047cf3de2e43724c2e30b167
Change-Id: Id68b57afed3b376a6f18ad2ce20a976a7d27c666 Signed-off-by: Frank Gasdorf <[email protected]>
60c7049
to
32c70c1
Compare
to have a common way to log messages overall modules. Reduces
code-duplications as well, if deprecated methods are removed
in the future
Signed-off-by: Frank Gasdorf [email protected]