Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Command Factories & restructures Commands #436

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Cleanup Command Factories & restructures Commands #436

wants to merge 1 commit into from

Conversation

fgdrf
Copy link
Contributor

@fgdrf fgdrf commented Dec 9, 2020

Cleanup and Refactor Code:

  • removes deprecated Command Factories
  • using packages w/o "internal" to allow to used Commands wherever required
  • slitting up command implementation from API into seperate bundles, e.g. navigation, selection and edit commands

WORK IN PROGRESS!!

@fgdrf fgdrf force-pushed the F_SetScaleCmd_as_NavCommand branch from 6c5c49a to 4b7e368 Compare December 9, 2020 13:56
@fgdrf fgdrf requested a review from moovida January 9, 2021 18:03
@fgdrf fgdrf changed the title F set scale cmd as nav command SetScaleCommand as NavCommand Jan 9, 2021
@sschulz92
Copy link
Contributor

Some of the changes are already merged, see: #465

What about this Pull Request? Do you want to keep it and change the title of the PR?

@fgdrf
Copy link
Contributor Author

fgdrf commented Sep 6, 2021

I'm going to rebase it to get refactorings into codebase as well

@fgdrf fgdrf force-pushed the F_SetScaleCmd_as_NavCommand branch from 4b7e368 to 0e8db04 Compare September 9, 2021 14:40
@fgdrf fgdrf changed the title SetScaleCommand as NavCommand Cleanup Command Factories & restructures Commands Sep 10, 2021
@fgdrf fgdrf mentioned this pull request Oct 4, 2021
Merged
@fgdrf
Refactoring (Nav)Commands
a9410d3 
Change-Id: I9a9fba0a7f96014c357a77f22aff213634fe2231
Signed-off-by: Frank Gasdorf <[email protected]>
@fgdrf fgdrf force-pushed the F_SetScaleCmd_as_NavCommand branch from 0e8db04 to a9410d3 Compare December 21, 2021 08:28
@fgdrf fgdrf mentioned this pull request Jan 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moovida moovida Awaiting requested review from moovida

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgdrf @sschulz92