-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-89: initial support for NTv2 #98
Conversation
Signed-off-by:Bart Hanssens <[email protected]>
Signed-off-by:Bart Hanssens <[email protected]>
Wow, this is so nice! Could you add some test coverage as well? |
Sure, still tinkering with it (I guess I could add detection of endianness). Currently it seems to work for a gsb file used in Belgium (https://www.ngi.be/website/wp-content/uploads/2020/07/NTv2-1.zip, CC-BY, about 5 MB size), but open to suggestions for smaller/other test files. |
@barthanssens I was able to find europe/100800401.gsb 25.2 KB Hopefully should work?
|
Signed-off-by:Bart Hanssens <[email protected]>
Thanks @pomadchin , I'll give that one a try |
Signed-off-by:Bart Hanssens <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you and congratz with the first contribution!
Initial NTv2 parser (only one subgrid, little endian format), as suggested in #89
Signed-off-by:Bart Hanssens [email protected]