Read Multiplex Band Support #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echeipesh
requested changes
Dec 10, 2018
There was a problem hiding this comment.
There is a major logic problem with the implementation that would yield incorrect results for non-trivial cases. The test does not reveal it because it uses only two files as input. This input is small enough that they will never be split by a partition.
Although a little outdated now here is an example of a required approach:
- Generate
RasterRegionsperSpatialKey - perform shuffle by key to co-locate all spatially overlapping input
- "sort"
RasterRegionsby key to get the right band order.
geopyspark-backend/geotrellis/src/main/scala/geopyspark/geotrellis/vlm/RasterSource.scala
Outdated
Show resolved
Hide resolved
geopyspark-backend/geotrellis/src/main/scala/geopyspark/geotrellis/vlm/RasterSource.scala
Outdated
Show resolved
Hide resolved
geopyspark-backend/geotrellis/src/main/scala/geopyspark/geotrellis/vlm/RasterSource.scala
Outdated
Show resolved
Hide resolved
geopyspark-backend/geotrellis/src/main/scala/geopyspark/geotrellis/vlm/RasterSource.scala
Outdated
Show resolved
Hide resolved
echeipesh
reviewed
Jan 17, 2019
geopyspark-backend/geotrellis/src/main/scala/geopyspark/geotrellis/vlm/RasterSource.scala
Outdated
Show resolved
Hide resolved
geopyspark-backend/geotrellis/src/main/scala/geopyspark/geotrellis/vlm/RasterSource.scala
Outdated
Show resolved
Hide resolved
geopyspark-backend/geotrellis/src/main/scala/geopyspark/geotrellis/vlm/RasterSource.scala
Outdated
Show resolved
Hide resolved
geopyspark-backend/geotrellis/src/main/scala/geopyspark/geotrellis/vlm/RasterSource.scala
Outdated
Show resolved
Hide resolved
geopyspark-backend/geotrellis/src/main/scala/geopyspark/geotrellis/vlm/RasterSource.scala
Outdated
Show resolved
Hide resolved
jbouffard
changed the title
jbouffard
changed the title
…g is done when reading in and formatting the data
…e when reading in and formatting the data
jbouffard
force-pushed
the
improvement/read-multiplex
branch
from
f8c2538 to
b4783bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multiplex band support to the
TiledRasterLayer.readmethod. Now, it'll be possible to read in separate files as a single multiband. This is useful in cases where individual bands are split into separate files. In addition to combing multiple bands into a single tile, it's also possible to specify their order. In order to support band multiplexing, a new type:SourceInfohas been created.Note: This PR depends on an unmerged PR: geotrellis/geotrellis-contrib#111 to work.