-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and use Cholesky decomposition for correlated_values
and correlated_values_norm
#271
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 96.50% 96.56% +0.05%
==========================================
Files 16 16
Lines 1919 1951 +32
==========================================
+ Hits 1852 1884 +32
Misses 67 67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR is ready for review. |
While this PR is ready for review, it's going to conflict badly with #262. Let's hold off on this one until after that one. |
pre-commit run --all-files
with no errorsClean up
correlated_values
andcorrelated_values_norm
. Make the code easier to follow. Also use the more efficient Cholesky decomposition in cases where the user-provided covariance matrix is positive-definite. If it is strictly positive semi-definite then use the eigenvalue decomposition that was previously used.Note, previously
correlated_values_norm
(which accepts a normalized correlation matrix) did the numerical lifting andcorrelated_values
(which accepts a covariance matrix) calledcorrelated_values_norm
. This is reversed now. Nowcorrelated_values
does the numerical work andcorrelated_values_norm
callscorrelated_values
.