Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some <py3.3 code #250

Merged
merged 5 commits into from
Jul 13, 2024
Merged

Remove some <py3.3 code #250

merged 5 commits into from
Jul 13, 2024

Conversation

andrewgsavage
Copy link
Contributor

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (64e7320) to head (9b63b19).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   95.77%   95.80%   +0.03%     
==========================================
  Files          15       15              
  Lines        1916     1908       -8     
==========================================
- Hits         1835     1828       -7     
+ Misses         81       80       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wshanks
wshanks previously approved these changes Jul 13, 2024
Copy link
Collaborator

@wshanks wshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I had one question, but I am fine with merging if you prefer the way the code is now.

uncertainties/core.py Outdated Show resolved Hide resolved
@newville
Copy link
Member

+1 from me!

@andrewgsavage andrewgsavage merged commit 9e0ba9a into lmfit:master Jul 13, 2024
19 checks passed
@andrewgsavage andrewgsavage deleted the old branch July 13, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants