-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to start/end instead of left/right to support RTL layouts #498
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ibrahim AshShohail <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ibrasho for this PR!
Just to give a context as this will improve the adaptability for different languages as using left
and right
is static—it assumes all languages are left-to-right (LTR), like English. But in right-to-left (RTL) languages like Arabic or Hebrew, layouts are often mirrored. start
and end
dynamically adjust based on the text direction.
start
aligns to the left
in LTR languages and to the right
in RTL languages. Similarly, end aligns to the right
in LTR and to the left
in RTL.
It also for internationalization (i18n) as this change is crucial for supporting applications used by people from different cultures and languages. By using start
and end
, the layout automatically adjusts to the user's language preference, improving usability for RTL users.
Long time no seee @ibrasho 🙋🏻♂️
I have published all the components for Flux (Flux and Flux-Pro), and here are my observations: Adding RTL (Right-to-Left) support to Flux can be completed in 30 minutes to 1 hour at most. Implementing RTL support in Flux is a straightforward process and can be done efficiently. |
Any update on this? |
Hey @calebporzio , Is this something you would be looking to add to Flux (and Flux Pro)? |
Looking forward to this |
This PR makes some changes to the tailwind classes used to support RTL layouts.
I'm applying similar changes to my local version of the pro files.