Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sam2 commit #217

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Pin sam2 commit #217

merged 2 commits into from
Oct 2, 2024

Conversation

pschroedl
Copy link
Collaborator

Pins the dependency on facebook/sam2 to unbreak our sam2 pipeline.

With our workflow pulling from upstream main, we encountered:

    raise MissingConfigException(
hydra.errors.MissingConfigException: Cannot find primary config 'configs/sam2/sam2_hiera_l.yaml'. Check that it's in your config search path.

Others have reported this issue as well:
facebookresearch/sam2#346

@pschroedl pschroedl requested a review from rickstaa as a code owner October 1, 2024 23:54
@pschroedl pschroedl requested a review from thomshutt October 1, 2024 23:55
Copy link
Collaborator

@eliteprox eliteprox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing the build! This is a temporary fix until the sam-2 repository is updated with a solution

@pschroedl pschroedl merged commit ddda616 into main Oct 2, 2024
2 of 3 checks passed
@rickstaa rickstaa deleted the pin_sam2_commit branch October 2, 2024 05:23
eliteprox pushed a commit that referenced this pull request Oct 8, 2024
* pin sam2 repo to commit before renaming and path changes

* update repo dependency to match upstream renaming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants