Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added(server): endpoint to retrieve all tutors that a user has not started a chat with yet. #260

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

mmoehabb
Copy link
Collaborator

@mmoehabb mmoehabb commented Dec 30, 2024

@mmoehabb mmoehabb self-assigned this Dec 30, 2024
@neuodev
Copy link
Member

neuodev commented Dec 30, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@mmoehabb mmoehabb requested review from neuodev, mostafakamar2308 and moalidv and removed request for moalidv December 30, 2024 00:32
@neuodev neuodev requested a review from moalidv December 30, 2024 10:10
@mmoehabb mmoehabb force-pushed the moehab/find-new-tutors branch from d2e3386 to 9ac753e Compare December 30, 2024 19:26
@neuodev
Copy link
Member

neuodev commented Dec 30, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@neuodev
Copy link
Member

neuodev commented Dec 30, 2024

@mmoehabb please attache the clickup task url

@mmoehabb mmoehabb force-pushed the moehab/find-new-tutors branch from 9ac753e to eb5ac9f Compare December 30, 2024 21:43
@neuodev
Copy link
Member

neuodev commented Dec 30, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

Copy link
Member

@neuodev neuodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I left minor comments. Please take a look.

Let's reflect the naming across this PR from "new tutors" to "uncontacted tutors"

packages/atlas/src/user.ts Outdated Show resolved Hide resolved
packages/atlas/src/user.ts Show resolved Hide resolved
packages/models/src/tutors.ts Show resolved Hide resolved
packages/models/src/tutors.ts Outdated Show resolved Hide resolved
packages/models/src/tutors.ts Outdated Show resolved Hide resolved
packages/models/src/tutors.ts Outdated Show resolved Hide resolved
packages/models/tests/tutors.test.ts Outdated Show resolved Hide resolved
packages/models/tests/tutors.test.ts Show resolved Hide resolved
packages/types/src/tutor.ts Outdated Show resolved Hide resolved
@mmoehabb mmoehabb force-pushed the moehab/find-new-tutors branch from eb5ac9f to 4adfccb Compare December 31, 2024 12:22
@neuodev
Copy link
Member

neuodev commented Dec 31, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@mmoehabb mmoehabb requested a review from neuodev December 31, 2024 12:30
packages/types/src/tutor.ts Outdated Show resolved Hide resolved
@mmoehabb mmoehabb force-pushed the moehab/find-new-tutors branch from 4adfccb to 104fec4 Compare January 1, 2025 11:17
@neuodev
Copy link
Member

neuodev commented Jan 1, 2025

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@mmoehabb mmoehabb merged commit e566c0b into master Jan 1, 2025
4 checks passed
@mmoehabb mmoehabb deleted the moehab/find-new-tutors branch January 1, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants