Related to #53 the neighborhood graph is not connected #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iglesias
changed the title
iglesias
changed the title
lisitsyn
reviewed
Apr 8, 2024
| { | ||
| if (!is_connected(begin, end, neighbors)) | ||
| LoggingSingleton::instance().message_warning("The neighborhood graph is not connected."); | ||
| LoggingSingleton::instance().message_warning("The neighborhood graph with " + std::to_string(k) + |
There was a problem hiding this comment.
Would you mind to use format there?
There was a problem hiding this comment.
Ah, nice one, thanks.
| @@ -190,10 +191,18 @@ Neighbors find_neighbors(NeighborsMethod method, const RandomAccessIterator& beg | |||
| neighbors = find_neighbors_covertree_impl(begin, end, callback, k); | |||
| #endif | |||
|
|
|||
| if (check_connectivity) | |||
| if (check_connectivity and !is_connected(begin, end, neighbors)) | |||
iglesias
force-pushed
the
53-the-neighborhood-graph-is-not-connected
branch
from
571029a to
ac425b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get started :-)
There's a small include update in a unit test too.