Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a display command. #436

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

rminnich
Copy link
Contributor

The display command uses the plan9ports devdraw device, and the 9fans devdraw Go support, to allow a display of the state of the buffer.

Currently, a user can do something like this:

Set up so devdraw command is in $PATH

PLAN9=/Users/rminnich/Documents/plan9 export PLAN9 PATH=$PATH:$PLAN9/bin export PATH

Now run utk

utk ~/Downloads/SBIOS_P5043_PG535_SKU_893_02.02.03_rel_prod.rom
display start
remove_dxes_except list
display end

The result will be two windows, one showing before, and one after.

The plan is that this can get fancier:

utk ~/Downloads/SBIOS_P5043_PG535_SKU_893_02.02.03_rel_prod.rom
display start
remove Http.*
display nohttp
remove_dxes_except list
display end

Also, note, although we only set up one pixel for each point, devdraw is nice to you: if you grow the window it grows the display of ROM. Also, the border is necessery for OSX with its rounded edges.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 2.12766% with 46 lines in your changes missing coverage. Please review.

Project coverage is 41.46%. Comparing base (41e39fd) to head (6df8aef).

Files with missing lines Patch % Lines
pkg/visitors/display.go 2.12% 45 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   41.63%   41.46%   -0.18%     
==========================================
  Files         142      143       +1     
  Lines       10728    10775      +47     
==========================================
+ Hits         4467     4468       +1     
- Misses       5393     5438      +45     
- Partials      868      869       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rminnich
Copy link
Contributor Author

image

@rminnich
Copy link
Contributor Author

And, yeah, note, they all look the same. Still not sure why.

@orangecms
Copy link
Collaborator

And, yeah, note, they all look the same. Still not sure why.

Can you dump the intermediate states to files and just diff?

@orangecms
Copy link
Collaborator

image

just tried this myself, with an empty list, expecting all the DXEs to go down the drain - which should result in a big change, but it looks the same

The display command uses the plan9ports devdraw device, and
the 9fans devdraw Go support, to allow a display of the state of the
buffer.

Currently, a user can do something like this:

Set up so devdraw command is in $PATH

PLAN9=/Users/rminnich/Documents/plan9 export PLAN9
PATH=$PATH:$PLAN9/bin export PATH

Now run utk

utk  ~/Downloads/SBIOS_P5043_PG535_SKU_893_02.02.03_rel_prod.rom  \
	display start \
	remove_dxes_except list  \
	display end

The result will be two windows, one showing before, and one after.

The plan is that this can get fancier:

utk  ~/Downloads/SBIOS_P5043_PG535_SKU_893_02.02.03_rel_prod.rom  \
	display start \
	remove Http.* \
	display nohttp \
	remove_dxes_except list  \
	display end

Also, note, although we only set up one pixel for each point, devdraw is nice to you:
if you grow the window it grows the display of ROM. Also, the border is necessery for OSX
with its rounded edges.

But: it's still not drawing the image correctly. Me and graphics.

Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
Waiting for someone who is good at this to fix it.

Signed-off-by: Ronald G. Minnich <[email protected]>
@orangecms
Copy link
Collaborator

@rminnich here is a fixup for the rendering rminnich#1

@orangecms
Copy link
Collaborator

image

it looks like the issue is with the remove_dxes_except command - with just a simple remove, I do see a difference now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants