Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/abi stack buffer overflow #100

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Bugfix/abi stack buffer overflow #100

wants to merge 4 commits into from

Conversation

mgrzeschik
Copy link
Contributor

I reworked the branch from @wdl-creston #72 and found that the changes can actually be split up which make the actual ABI change more obvious.

@mgrzeschik
Copy link
Contributor Author

The first three patches are noninvasive and should not change the ABI. I could move them to another MR and add them to the 0.3.0 release. @wdl83 What do you think? Can you review them?

@mgrzeschik mgrzeschik requested a review from pabs3 September 25, 2024 13:20
@mgrzeschik mgrzeschik mentioned this pull request Oct 16, 2024
Open
@wdl83
Copy link

wdl83 commented Oct 23, 2024 •
edited
Loading

The first three patches are noninvasive and should not change the ABI. I could move them to another MR and add them to the 0.3.0 release. @wdl83 What do you think? Can you review them?

Hi, not sure which changes are not affecting ABI, looks like 99% does. Does it make sense to split anything?

BTW: this is the change needed to get VIDEO streaming working with dummy_hcd.
I took you patch as base and fixed a few issues. I was able to correctly stream MJPEG and H264 with my framebased changes to usb-gadgets (branch on my fork).
wdl83/linux@master...wdl83:linux:dummy_hcd_ISOC_v6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdl83 wdl83 wdl83 approved these changes

@pabs3 pabs3 Awaiting requested review from pabs3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgrzeschik @wdl83