-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] : add unittests for vpc.go file #281
Conversation
} | ||
} | ||
|
||
func TestGetVPCID(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qq: any reason to not use tabular test format for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ListVPCs()
call and its response is changing in each test run, hence I avoided tabular format. Not sure if we can achieve that with tabular format unless we do if/else with bunch of conditions to decide which mock call to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah i see. I'm okay with that
c311539
to
9bc2a2d
Compare
61792ad
to
c22c0e5
Compare
c22c0e5
to
cff5c44
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 56.63% 57.92% +1.29%
==========================================
Files 12 12
Lines 2412 2415 +3
==========================================
+ Hits 1366 1399 +33
+ Misses 892 864 -28
+ Partials 154 152 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
General:
Pull Request Guidelines: