Fix e2e workflow #70
Merged
Fix e2e workflow #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
lgarber-akamai and
ykim-akamai
and removed request for
a team
lgarber-akamai
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Works well on my fork, nice work!
For the TOD failure, would it make sense to split the test result upload out into a separate job like we do in Terraform or add an condition to only run the upload if the repo is under the Linode namespace?
ykim-akamai
approved these changes
Oct 25, 2024
I can create a ticket to improve the workflow including the condition you mentioned and slack notifications for both go/py metadata |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This is to fix the E2E workflow
✔️ How to Test
Test result: https://github.com/zliang-akamai/go-metadata/actions/runs/11506089637/job/32029239414
The failure above was caused by TOD uploading, rather than E2E itself, because I can't setup TOD in my fork.