Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests #31

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

ykim-akamai
Copy link
Contributor

📝 Description

This PR adds initial set of unit tests for following files:

  • instance.go
  • network.go
  • sshkeys.go
  • userdata.go
  • watchers.go and watchers_generic.go

Each unit test suite for each file covers the successful and error responses

✔️ How to Test

make test-unit

How do I run the relevant unit/integration tests?

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai requested a review from a team as a code owner January 18, 2024 00:52
@ykim-akamai ykim-akamai requested review from jriddle-linode and vshanthe and removed request for a team January 18, 2024 00:52
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing locally, nice work!

Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM everything passing locally.

@ykim-akamai ykim-akamai merged commit 1bd6512 into linode:main Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants