ref: (BREAKING) Use map for Client.GetSSHKeys(...) response #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
added
enhancement
lgarber-akamai
requested review from
yec-akamai and
vshanthe
and removed request for
a team
yec-akamai
approved these changes
Jan 12, 2024
Co-authored-by: Ye Chen <[email protected]>
vshanthe
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This change updates the response struct for
Client.GetSSHKeys(...)to return amap[string][]stringrather than theSSHKeysUserDatastruct. This is necessary because the MDS API can return SSH keys for arbitrary users configured using cloud-config.✔️ How to Test
The following test steps assume you have pulled this branch down locally.
E2E Testing:
Manual Testing:
TODO