Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linters and the formatter #17

Merged
merged 14 commits into from
Dec 13, 2023
Merged

Add linters and the formatter #17

merged 14 commits into from
Dec 13, 2023

Conversation

zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Dec 8, 2023 •
edited
Loading

📝 Description

This PR is for adding linters

✔️ How to Test

Note: we will have to merge another PR to fix the watcher in order to test this PR.

  • Test lint checking with docker
    • Install docker if you haven't done it before.
    • make lint
  • Test docker can be skipped
    • Install golangci-lint locally without the docker
    • SKIP_DOCKER=1 make lint
  • Test auto fix lint
    • Randomly mess up some code format
    • make fix-lint
    • Observe whether golangci-lint run --fix is running.
    • Note that some lint issues cannot be automatically fixed by this command.

@zliang-akamai zliang-akamai requested a review from a team as a code owner December 8, 2023 23:09
@zliang-akamai zliang-akamai requested review from jriddle-linode and yec-akamai and removed request for a team December 8, 2023 23:09
@zliang-akamai zliang-akamai changed the title Add golangci-lint Add linters and the formatter Dec 8, 2023
@zliang-akamai zliang-akamai force-pushed the zhiwei/add-golangci-lint branch from fa9e71a to 81e31d1 Compare December 9, 2023 01:54
@zliang-akamai zliang-akamai force-pushed the zhiwei/add-golangci-lint branch from 81e31d1 to ccd468b Compare December 9, 2023 02:05
lgarber-akamai
lgarber-akamai reviewed Dec 11, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
lgarber-akamai
lgarber-akamai approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make lint passes as expected locally, great work!

lgarber-akamai
lgarber-akamai approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great!

jriddle-linode
jriddle-linode approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zliang-akamai zliang-akamai merged commit b38eb87 into main Dec 13, 2023
1 check passed
@zliang-akamai zliang-akamai deleted the zhiwei/add-golangci-lint branch December 13, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

@jriddle-linode jriddle-linode jriddle-linode approved these changes

@yec-akamai yec-akamai Awaiting requested review from yec-akamai yec-akamai is a code owner automatically assigned from linode/dx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zliang-akamai @jriddle-linode @lgarber-akamai