Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test enhancement #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

peter279k
Copy link
Member

Changed log

  • Remove php-7.3-RC because the php-7.3 has been released by official PHP.
  • Using the assertFalse to check whether the expected result is false.
  • Using the assertIsInt to check whether expected value type is int.
  • Using the short array syntax for test cases because of consistency.
  • Replace if-else condition with ?: and single statement to enhance the conditional statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant