TW-2165: Improve tag suggestion with members in room #2200
+129
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqhhdev
requested review from
hoangdat,
dab246 and
tddang-linagora
as code owners
nqhhdev
force-pushed
the
TW-2165-improve-tag-suggesstion
branch
from
17b88db to
0ff9bc3
Compare
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2200 |
hoangdat
reviewed
Dec 29, 2024
| @@ -59,6 +61,8 @@ mixin ChatDetailsTabMixin<T extends StatefulWidget> | |||
| static const _mediaFetchLimit = 20; | |||
| static const _linksFetchLimit = 20; | |||
| static const _filesFetchLimit = 20; | |||
| static const _maxMembers = 30; | |||
There was a problem hiding this comment.
not get this idea? what is it?
There was a problem hiding this comment.
I wrote ADR for this ticket, pls check it more details related to _maxMembers variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Need merge
Resolved
Screen.Recording.2024-12-23.at.23.55.16.mov