Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-3341 Enable web socket for mobile #3357

Merged
merged 2 commits into from
Dec 23, 2024
Merged

TF-3341 Enable web socket for mobile #3357

merged 2 commits into from
Dec 23, 2024

Conversation

tddang-linagora
Copy link
Contributor

@tddang-linagora tddang-linagora commented Dec 17, 2024 •
edited
Loading

Issue

Dependency (for integration test)

Demo

Screen.Recording.2024-12-17.at.14.52.30.mov

@tddang-linagora tddang-linagora self-assigned this Dec 17, 2024
@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3357.

@dab246
Copy link
Member

dab246 commented Dec 18, 2024 •
edited by tddang-linagora
Loading

  • Please demo video for integration test.

@tddang-linagora
Copy link
Contributor Author

Please demo video for integration test.

web-socket-integration-test.webm

@tddang-linagora tddang-linagora marked this pull request as ready for review December 18, 2024 09:27
@tddang-linagora tddang-linagora force-pushed the feature/TF-3341-web-socket-mobile branch from a5eef84 to da1f8e1 Compare December 19, 2024 09:14
@tddang-linagora tddang-linagora changed the base branch from master to maintenance-v0.14.2 December 19, 2024 09:15
@tddang-linagora tddang-linagora force-pushed the feature/TF-3341-web-socket-mobile branch from da1f8e1 to 2a7f480 Compare December 19, 2024 10:25
@hoangdat
Copy link
Member

hoangdat commented Dec 20, 2024 •
edited by tddang-linagora
Loading

  • profiling memory leak
    • open app ↔ go home in phone rapidly in many times
    • ...

@tddang-linagora tddang-linagora mentioned this pull request Dec 20, 2024
Merged
dab246
dab246 reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment •
edited by tddang-linagora
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Web socket (ping) still call when app on background state
Screen.Recording.2024-12-20.at.13.04.47.mov

integration_test/utils/scenario_utils_mixin.dart Outdated Show resolved Hide resolved
integration_test/utils/scenario_utils_mixin.dart Outdated Show resolved Hide resolved
integration_test/utils/scenario_utils_mixin.dart Outdated Show resolved Hide resolved
lib/features/mailbox_dashboard/presentation/controller/mailbox_dashboard_controller.dart Outdated Show resolved Hide resolved
lib/features/push_notification/presentation/controller/web_socket_controller.dart Outdated Show resolved Hide resolved
lib/features/push_notification/presentation/controller/web_socket_controller.dart Show resolved Hide resolved
lib/features/push_notification/presentation/controller/web_socket_controller.dart Outdated Show resolved Hide resolved
lib/features/push_notification/presentation/services/fcm_service.dart Show resolved Hide resolved
@tddang-linagora
Copy link
Contributor Author

Web socket (ping) still call when app on background state

Screen.Recording.2024-12-20.at.14.08.13.mov

I can't reproduce it. Did you run with the latest changes?

@tddang-linagora
Copy link
Contributor Author

profiling memory leak

profile-memory-web-socket-mobile.mov

@dab246
Copy link
Member

dab246 commented Dec 23, 2024

Web socket (ping) still call when app on background state

Screen.Recording.2024-12-20.at.14.08.13.mov
I can't reproduce it. Did you run with the latest changes?

Try again, I used the latest changes on the branch and ran it. It still has that error.

Screen.Recording.2024-12-23.at.09.03.55.mov
  • On the other hand, there is no notification on android in background mode anymore. Please check this case again.

@tddang-linagora
Copy link
Contributor Author

there is no notification on android in background mode anymore. Please check this case again.

Reproducible on master branch.

@dab246
Copy link
Member

dab246 commented Dec 23, 2024

Web socket (ping) still call when app on background state

Try again, I used the latest changes on the branch and ran it. It still has

Tested again. It work well.

@tddang-linagora tddang-linagora force-pushed the feature/TF-3341-web-socket-mobile branch from fc0a616 to d2c7289 Compare December 23, 2024 04:07
dab246
dab246 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoangdat hoangdat merged commit 918cfe7 into maintenance-v0.14.2 Dec 23, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibenwa chibenwa chibenwa left review comments

@dab246 dab246 dab246 approved these changes

@hoangdat hoangdat hoangdat approved these changes

Assignees

@tddang-linagora tddang-linagora

Labels
customer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tddang-linagora @dab246 @hoangdat @chibenwa