-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-3316 Fix inconsistent vacation message #3330
Open
tddang-linagora
wants to merge
1
commit into
master
Choose a base branch
from
fixbug/TF-3316-inconsistent-vacation-message
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TF-3316 Fix inconsistent vacation message #3330
tddang-linagora
wants to merge
1
commit into
master
from
fixbug/TF-3316-inconsistent-vacation-message
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tddang-linagora
temporarily deployed
to
PR-3330
December 9, 2024 08:24 — with
GitHub Actions
Inactive
This PR has been deployed to https://linagora.github.io/tmail-flutter/3330. |
dab246
reviewed
Dec 9, 2024
lib/features/manage_account/presentation/extensions/vacation_response_extension.dart
Outdated
Show resolved
Hide resolved
tddang-linagora
temporarily deployed
to
PR-3330
December 10, 2024 07:48 — with
GitHub Actions
Inactive
dab246
previously approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please rebase it
tddang-linagora
force-pushed
the
fixbug/TF-3316-inconsistent-vacation-message
branch
from
December 11, 2024 08:53
4a9dd7e
to
0fefb12
Compare
dab246
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Dependency
textBody
ofVacationResponse
to be null jmap-dart-client#101Before
After