Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PART-1] TF-2646 Enable selection all emails in mailbox #2842

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

dab246
Copy link
Member

@dab246 dab246 commented May 2, 2024

Issue

#2646

Dependent

Demo

Screen.Recording.2024-05-02.at.13.51.37.mov

Copy link

github-actions bot commented May 2, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/2842.

tddang-linagora
tddang-linagora previously approved these changes May 2, 2024
@chibenwa
Copy link
Member

chibenwa commented May 2, 2024

With that UX what happens if I select all mail visible, then select all mails, then unselect a few visible mails?

When selecting all mails (all all) then we should likely blur / disable actions not available. We could also merge them : Mark as read then becomes "mark all as read"

@dab246
Copy link
Member Author

dab246 commented May 3, 2024

With that UX what happens if I select all mail visible, then select all mails, then unselect a few visible mails?

At that time selection all emails will be disabled (similar to Gmail's UX)

Screenshot 2024-05-03 at 08 33 55

When selecting all mails (all all) then we should likely blur / disable actions not available. We could also merge them : Mark as read then becomes "mark all as read"

When selection all emails is enabled. We only show actions that can be performed on all emails such as: mark all as read/unread, mark all as star, move all, move all to trash, mark all as spam. And of course the titles of these actions all have the word all

Screenshot 2024-05-03 at 08 38 22

@dab246 dab246 requested a review from chibenwa May 3, 2024 01:39
@dab246 dab246 force-pushed the tf-2646-enable-selection-all-emails-in-mailbox branch from 379171a to 4b62188 Compare December 11, 2024 02:26
@dab246 dab246 changed the base branch from v0.11.3-patch4-dev to master December 11, 2024 02:27
@dab246 dab246 dismissed tddang-linagora’s stale review December 11, 2024 02:27

The base branch was changed.

@tddang-linagora
Copy link
Contributor

tddang-linagora commented Dec 12, 2024

  • Please handle this case too

    • Select all emails
    • Tap on select all emails in mailbox
    • Drag to another mailbox
  • Current behavior: Only drag first 20 emails

  • Should be: Drag all emails in mailboxes

@hoangdat
Copy link
Member

hoangdat commented Dec 12, 2024

  • align text of banner to the left
  • no need highlights number of email with bold text.

Cc @Bobpodvalnyi

@dab246 dab246 force-pushed the tf-2646-enable-selection-all-emails-in-mailbox branch from 4b62188 to 28c7465 Compare December 16, 2024 05:56
@dab246
Copy link
Member Author

dab246 commented Dec 16, 2024

  • Please handle this case too

    • Select all emails
    • Tap on select all emails in mailbox
    • Drag to another mailbox
  • Current behavior: Only drag first 20 emails

  • Should be: Drag all emails in mailboxes

  • align text of banner to the left
  • no need highlights number of email with bold text.

Cc @Bobpodvalnyi

Fixed.

Screen.Recording.2024-12-16.at.12.51.06.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants