Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rpc server port addition #102

Conversation

king-11
Copy link

@king-11 king-11 commented Jan 14, 2024

  • add rpc server port assigment in integration tests
    Signed-off-by: Lakshya Singh [email protected]

@ksedgwic
Copy link

Please confirm that the CLN integration tests work with a fix

Does this work in CLN integration tests?

@devrandom
Copy link
Collaborator

ACK

@king-11
Copy link
Author

king-11 commented Jan 21, 2024

Copy link

@ksedgwic ksedgwic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!

I think you have one non-intentional file mod? See below ...

Otherwise ready

lightningd/remote_hsmd_inplace Outdated Show resolved Hide resolved
@ksedgwic
Copy link

I'm ok merging if we resolve the maybe extraneous file bit above

@king-11 king-11 force-pushed the lakshya/rpc-server-fix branch from fac5d1d to 2535190 Compare January 23, 2024 02:33
@ksedgwic
Copy link

looks good, merging

@ksedgwic ksedgwic merged commit 94884de into lightning-signer:2023-12-hsmd-forget-channel Jan 23, 2024
@king-11 king-11 deleted the lakshya/rpc-server-fix branch January 23, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants