feat: move send to wallet logic to new bookmark component #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Task LF-4928 · Bookmark for wallets |
…ss/ens are correct
0xsebn
changed the title
|
For the first milestone where the goal is to display exchange warning message missing the -styling of the SendToWallet component (switching it to a clickable button instead of an input) |
chybisov
previously approved these changes
Oct 16, 2023
packages/widget/src/components/SendToWalletButton/ShowSendToWalletButton.tsx
Outdated
Show resolved
Hide resolved
|
For any other person possibly reviewing this atm, hopped on a call with Eugene and he gave me some more comments. Will put the wait tag for now till I finish those |
…am using invalid field now, also onchange triggers validate
… clicking somehwere on the page
|
Finished in #168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task:
This task solves:
https://lifi.atlassian.net/browse/LF-2839
and
https://lifi.atlassian.net/browse/LF-5322
Task was initially linked to what is now the epic.
https://lifi.atlassian.net/jira/software/c/projects/LF/boards/15?modal=detail&selectedIssue=LF-4928&assignee=6398600d3c9bcd363977188e
Created bookmark page where user is able to input wallet address and on clicking confirm gets sent to main page.
This is part 1 of creating the bookmark functionality. The component to switch from "Custom" to "Bookmarks" is hidden atm.