Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the use of regenerator in the build #5703

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

matuzalemsteles
Copy link
Member

Well, we are deleting transform-regenerator so that we can use the Generator feature and consequently we can now also use async/await instead of continuing to use then for Promise, these are features that have been supported by the browser for a long time and is also included within our compatibility matrix.

@matuzalemsteles
Copy link
Member Author

cc @bryceosterhaus @ethib137

@bryceosterhaus
Copy link
Member

This looks like it should fix out problems in DXP. I tested a local build too and verified that it no-longer requires a global of regeneratorRuntime

@bryceosterhaus
Copy link
Member

Feel free to merge and publish a new version of clay and then I can test in DXP tomorrow.

@ethib137
Copy link
Member

Would this fix the issue I've started seeing in codesandbox as well: https://codesandbox.io/s/language-selector-picker-example-iq811m?file=/src/index.js:0-66

Screenshot 2023-10-26 at 3 21 58 PM

@matuzalemsteles
Copy link
Member Author

@ethib137 It's not possible to test on codesandbox yet because we haven't published the packages with this change yet, so we're just checking the build result locally.

@matuzalemsteles matuzalemsteles merged commit fd01dce into liferay:master Oct 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants