LPS-201972 Implement a FeatureIndicator JS component in DXP #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
Hey @pat270 , this is looking pretty good. One thing, it looks like you're missing the small and rounded utilities being added to the button, right? For getting the learn message to work, did you see this example. I think you have to pass in the learnResourceContext from the backend. |
- deprecated
- deprecated-feature
- open-deprecated-definition
- this-feature-is-deprecated
|
Resent to FI at liferay-frontend#3879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPS-201972
I'm sending this as draft for review. It doesn't look correct because we need liferay/clay#5711 to be available in portal. I'm missing
darkandtranslucentattributes in the component. The build fails when I add them.The syntax for this would look like:
One thing I couldn't figure out is how to get the Learn message to show.