Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add legacy support via plugin #164

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add legacy support via plugin #164

merged 1 commit into from
Nov 14, 2024

Conversation

soun059
Copy link
Contributor

@soun059 soun059 commented Nov 6, 2024 •
edited
Loading

Add legacy in build config & nonce in scripts for outlook webview support.

Related: #143

@soun059 soun059 force-pushed the soujanna/lico-legacy-support branch from 8b12308 to 52c4be4 Compare November 6, 2024 07:28
longsleep
longsleep requested changes Nov 6, 2024
View reviewed changes
identifier/index.html Outdated Show resolved Hide resolved
@soun059 soun059 force-pushed the soujanna/lico-legacy-support branch from 52c4be4 to 53c8625 Compare November 6, 2024 09:57
longsleep
longsleep requested changes Nov 6, 2024
View reviewed changes
identifier/api.go Outdated Show resolved Hide resolved
identifier/api.go Outdated Show resolved Hide resolved
identifier/vite.config.js Outdated Show resolved Hide resolved
identifier/vite.config.js Outdated Show resolved Hide resolved
@soun059 soun059 force-pushed the soujanna/lico-legacy-support branch 5 times, most recently from e47f9aa to 959a98f Compare November 11, 2024 07:38
longsleep
longsleep requested changes Nov 11, 2024
View reviewed changes
identifier/vite.config.js Outdated Show resolved Hide resolved
identifier/vite.config.js Outdated Show resolved Hide resolved
@longsleep
Copy link
Collaborator

@soun059 please rebase this MR on master, to incorporate the latest changes.

@longsleep longsleep mentioned this pull request Nov 11, 2024
Closed
longsleep
longsleep requested changes Nov 11, 2024
View reviewed changes
identifier/package.json Outdated Show resolved Hide resolved
@longsleep
Copy link
Collaborator

This now looks good from the change itself, please deal with the remaining comments and update the commit message to resemble somewhich which follos the 7 rules of a great commit messages:

  • Separate subject from the body with a blank line
  • Limit the subject line to 50 characters
  • Summary in the present tense. Not capitalized.
  • Do not end the subject line with a period
  • Use the imperative mood in the subject line
  • Wrap the body at 72 characters
  • Use the body to explain what and why vs. how

Try to summarize the change and then give details why this change is needed. Also please do not include "lico" or any other implicitly clear information in the commit summary or description.

@longsleep longsleep added the enhancement New feature or request label Nov 11, 2024
@soun059 soun059 force-pushed the soujanna/lico-legacy-support branch 2 times, most recently from 6e41b72 to 507d95b Compare November 12, 2024 07:43
@soun059
Copy link
Contributor Author

soun059 commented Nov 12, 2024

@soun059 please rebase this MR on master, to incorporate the latest changes.

Rebased this with latest pull from master.

@soun059
Copy link
Contributor Author

soun059 commented Nov 12, 2024

This now looks good from the change itself, please deal with the remaining comments and update the commit message to resemble somewhich which follos the 7 rules of a great commit messages:

* Separate subject from the body with a blank line

* Limit the subject line to 50 characters

* Summary in the present tense. Not capitalized.

* Do not end the subject line with a period

* Use the imperative mood in the subject line

* Wrap the body at 72 characters

* Use the body to explain what and why vs. how

Try to summarize the change and then give details why this change is needed. Also please do not include "lico" or any other implicitly clear information in the commit summary or description.

Updated the commit message.

@soun059 soun059 changed the title Add Legacy Support for Lico Add legacy support via plugin Nov 12, 2024
@soun059 soun059 force-pushed the soujanna/lico-legacy-support branch from 507d95b to 28a3be8 Compare November 12, 2024 07:47
longsleep
longsleep requested changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@longsleep longsleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not happy with the commit message. Please be more precise in the summary and add details in the description without repeating the summary again.

@soun059
Add legacy support via plugin
95a5255 
Add legacy in build config & nonce in scripts for outlook webview support.

Related: libregraph#143
@soun059 soun059 force-pushed the soujanna/lico-legacy-support branch from 28a3be8 to 95a5255 Compare November 14, 2024 07:54
@soun059
Copy link
Contributor Author

soun059 commented Nov 14, 2024

I am still not happy with the commit message. Please be more precise in the summary and add details in the description without repeating the summary again.

Updated the commit description to substantiate more details.

@longsleep longsleep merged commit 5dc7794 into libregraph:master Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longsleep longsleep longsleep approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soun059 @longsleep