Fix branding settings cache usage

The branding settings are delivered as part of the initial hello and
then are cached in the state store. Any consumer must use the branding
settings from there instead from a potentially different hello state to
avoid loosing branding settings.

This fixes the flicker of the login form label and bottom text when the
login page is submitted.

identifier/src/containers/Login/Login.jsx

@@ -54,6 +54,7 @@ const styles = theme => ({
 function Login(props) {
   const {
     hello,
+    branding,
     query,
     dispatch,
     history,
@@ -93,21 +94,21 @@ function Login(props) {
   };
 
   const usernamePlaceHolder = useMemo(() => {
-    if (hello?.details?.branding?.usernameHintText ) {
-      switch (hello.details.branding.usernameHintText) {
+    if (branding?.usernameHintText ) {
+      switch (branding.usernameHintText) {
         case "Username":
           break;
         case "Email":
           return t("konnect.login.usernameField.placeholder.email", "Email");
         case "Identity":
           return t("konnect.login.usernameField.placeholder.identity", "Identity");
         default:
-          return hello.details.branding.usernameHintText;
+          return branding.usernameHintText;
       }
     }
 
     return t("konnect.login.usernameField.placeholder.username", "Username");
-  }, [hello, t]);
+  }, [branding, t]);
 
   return (
     <DialogContent>
@@ -164,7 +165,7 @@ function Login(props) {
           </Typography>
         ))}
 
-        {hello?.details?.branding?.signinPageText && <Typography variant="body2">{hello.details.branding.signinPageText}</Typography>}
+        {branding?.signinPageText && <Typography variant="body2">{branding.signinPageText}</Typography>}
       </form>
     </DialogContent>
   );

identifier/src/store.js

@@ -8,7 +8,7 @@ const middlewares = [
   thunkMiddleware
 ];
 
-if (process.env.NODE_ENV === 'development') { // eslint-disable-line no-undef
+if (process.env.NODE_ENV !== 'development') { // eslint-disable-line no-undef
   middlewares.push(createLogger()); // must be last middleware in the chain.
 }