Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jt/82 webrtcinrustping #84
Jt/82 webrtcinrustping #84
Changes from 18 commits
766c909
ad93609
65117e1
54466dd
2653436
a9a4f18
79b4441
b114212
2cc28e0
2d0bc4a
31666f5
31e8197
76b9283
8991625
89ce9f1
35869fe
e9c0ba4
5cae933
afe3a77
24c1f23
a8fefc2
c3207d2
8696244
c916d4b
3dab17b
26f311a
753cd1b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PeerId
supportsDisplay
so we don't need to useDebug
here. Would also be a nicer log message if we get a multi-address out ofendpoint
andDisplay
log that one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again,
info
is likely way too noisy.