Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebRTC transport interop ping test #67

Conversation

John-LittleBearLabs
Copy link

@John-LittleBearLabs John-LittleBearLabs commented Oct 26, 2022

Adding webrtc to the SupportedTransports in the composer version of the ping tests, which are in turn, I believe, also a work-in-progress.

Currently it depends heavily on https://github.com/ckousik/go-libp2p/tree/ckousik/webrtc since that has webrtc implemented for golang. Some goofy hacks are involved in getting that to work properly. We'll want to have that all sorted and webrtc merged in (and probably released) before this hits test-plans master.

@mxinden
Copy link
Member

mxinden commented Nov 2, 2022

@John-LittleBearLabs I am not quite sure what the goal is here, which is fine for now given that it is a draft. Let me know once this is ready for a review.

@John-LittleBearLabs
Copy link
Author

@mxinden

@John-LittleBearLabs I am not quite sure what the goal is here, which is fine for now given that it is a draft. Let me know once this is ready for a review.

Hopefully the new description helps to clear this up?

@GlenDC - I think you're pretty familiar with what I'm doing here. Does this all make sense to you? Assuming the answer is no, as this is rather opaque, perhaps the better question would be where should I elaborate more and/or things I should obviously fix right away.

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains many changes that are unrelated, i.e. that are already in master. @John-LittleBearLabs can you please clean up the commit history?

@p-shahi
Copy link
Member

p-shahi commented Nov 17, 2022

@John-LittleBearLabs
I'm not fully in the loop here but I don't think this branch should build on/target libp2p:feat/interop-dashboard anymore.
The composer has been changed by @jxs here: master...jxs:test-plans:add-composer as a part of #61

Things are changing quickly so it might be worth you and @jxs syncing up

WebRTC in rust-libp2p also just landed on master: libp2p/rust-libp2p#2622


In the go-libp2p triage meeting, we discussed this PR (as it relates to libp2p/go-libp2p#1655).
@MarcoPolo suggests that we pause this PR until we have a solid test-plans foundation (work by Joao is complete.)

@p-shahi p-shahi changed the title Interop transport Add WebRTC transport interop ping test Nov 17, 2022
@GlenDC
Copy link
Contributor

GlenDC commented Nov 18, 2022

@mxinden

@John-LittleBearLabs I am not quite sure what the goal is here, which is fine for now given that it is a draft. Let me know once this is ready for a review.

Hopefully the new description helps to clear this up?

@GlenDC - I think you're pretty familiar with what I'm doing here. Does this all make sense to you? Assuming the answer is no, as this is rather opaque, perhaps the better question would be where should I elaborate more and/or things I should obviously fix right away.

You’re doing more advanced testground work than me. I’m not yet at this level. There’s a lot i can learn from you. But from what i can see. This looks pretty good to me :) that being said, let’s perhaps meet tomorrow over video so I can pick some stuff up from you.

@laurentsenta laurentsenta force-pushed the feat/interop-dashboard branch 5 times, most recently from 9101865 to 26fb2b8 Compare November 23, 2022 14:53
@p-shahi p-shahi closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants