chore: parameterise s3 build cache setup #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you planning to make the bucket publicly accessible? As Protocol Labs' was previously? |
achingbrain
approved these changes
Sep 4, 2024
achingbrain
reviewed
Sep 4, 2024
achingbrain
reviewed
Sep 4, 2024
|
@achingbrain complementing @AlejandroCabeza question, is there any cache that can be used at the moment, or from now on projects using this repo will need to set up their own individually? |
Co-authored-by: Alex Potsides <[email protected]>
|
I don't know, sorry - you may need to stand your own s3 bucket up. If that adds too much overhead, you could apply for a grant from the libp2p foundation to contribute to a shared infrastructure? |
Alright, thanks for the answer! |
galargh
force-pushed
the
galargh/s3-build-cache
branch
4 times, most recently
from
572d20f to
31176a4
Compare
galargh
force-pushed
the
galargh/s3-build-cache
branch
from
31176a4 to
69f4fcc
Compare
achingbrain
reviewed
Sep 5, 2024
| const cachePath = fs.mkdtempSync(path.join(os.tmpdir(), 'cache')) | ||
| const archivePath = path.join(cachePath, 'archive.tar.gz') | ||
| const dockerLoadedMsg = child_process.execSync(`aws s3 cp s3://${AWS_BUCKET}/imageCache/${cacheKey}-${arch}.tar.gz ${archivePath} && docker image load -i ${archivePath}`).toString(); | ||
| const loadedImageId = dockerLoadedMsg.match(/Loaded image( ID)?: (.*)/)[2]; |
There was a problem hiding this comment.
Suggested change
| const loadedImageId = dockerLoadedMsg.match(/Loaded image( ID)?: (.*)/)[2]; | |
| const loadedImageId = dockerLoadedMsg.match(/Loaded image( ID)?: (.*)/)[2]; |
achingbrain
approved these changes
Sep 11, 2024
AlejandroCabeza
added a commit
to vacp2p/libp2p-test-plans
that referenced
this pull request
Sep 12, 2024
* upstream/master: chore: update the link to the interop dashboard [skip ci] chore: parameterise s3 build cache setup (libp2p#465) chore: Create funding.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're setting up a new cache bucket, we'd like to be able to control its' configuration via GitHub vars/secrets fully.