-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(transport-interop): add js-libp2p v0.46.21 #305
Conversation
@p-shahi would you remind giving this a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Though I have limited knowledge of js-libp2p only. Maybe @achingbrain can give a final approval?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of questions about dep versions inline
@achingbrain I've updated this PR to |
friendly ping @achingbrain if there are no objections here @mxinden I think we can proceed with merging so that we can enable the webRTC tests as mentioned in #310 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the package.json deps that aren't in direct use by this project, as they are currently the same ranges as versions the @libp2p/multidim-interop
module depends on so are redundant, but I don't want to block this any further ahead of demoing this week.
Also upgrade the dependencies