Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(transport-interop): add js-libp2p v0.46.21 #305

Merged
merged 8 commits into from
Nov 14, 2023

Conversation

maschad
Copy link
Member

@maschad maschad commented Sep 15, 2023

Also upgrade the dependencies

@maschad maschad marked this pull request as draft September 15, 2023 04:14
@maschad maschad marked this pull request as ready for review September 15, 2023 14:02
@maschad
Copy link
Member Author

maschad commented Sep 15, 2023

@p-shahi would you remind giving this a review?

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Though I have limited knowledge of js-libp2p only. Maybe @achingbrain can give a final approval?

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of questions about dep versions inline

multidim-interop/impl/js/v0.46/package.json Outdated Show resolved Hide resolved
multidim-interop/impl/js/v0.46/package.json Outdated Show resolved Hide resolved
@maschad maschad requested a review from achingbrain October 4, 2023 02:08
@maschad maschad changed the title chore(multidim): add js-libp2p v0.46.10 chore(multidim): add js-libp2p v0.46.14 Oct 10, 2023
@maschad maschad marked this pull request as draft October 10, 2023 22:16
@maschad maschad changed the title chore(multidim): add js-libp2p v0.46.14 chore(transport-interop): add js-libp2p v0.46.14 Oct 10, 2023
@maschad maschad marked this pull request as ready for review October 10, 2023 22:42
@maschad
Copy link
Member Author

maschad commented Oct 10, 2023

@achingbrain I've updated this PR to v0.46.14 so that we can test out the webRTC fixes in #310

@maschad
Copy link
Member Author

maschad commented Nov 2, 2023

friendly ping @achingbrain

if there are no objections here @mxinden I think we can proceed with merging so that we can enable the webRTC tests as mentioned in #310

@achingbrain
Copy link
Member

achingbrain commented Nov 3, 2023

[email protected] has shipped, it'd be good to test with that and all the latest patch releases of the other libp2p modules, otherwise all good from me.

@maschad maschad changed the title chore(transport-interop): add js-libp2p v0.46.14 chore(transport-interop): add js-libp2p v0.46.17 Nov 3, 2023
@maschad maschad changed the title chore(transport-interop): add js-libp2p v0.46.17 chore(transport-interop): add js-libp2p v0.46.21 Nov 14, 2023
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the package.json deps that aren't in direct use by this project, as they are currently the same ranges as versions the @libp2p/multidim-interop module depends on so are redundant, but I don't want to block this any further ahead of demoing this week.

@achingbrain achingbrain merged commit 6d4c701 into libp2p:master Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants