Skip to content

Commit

Permalink
chore: revert previous change
Browse files Browse the repository at this point in the history
  • Loading branch information
achingbrain committed Dec 9, 2024
1 parent 33f16a8 commit 6741822
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions transport-interop/impl/js/v2.x/Makefile
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
image_name := js-v2.x

# TODO Enable webkit once https://github.com/libp2p/js-libp2p/pull/1627 is in
all: clean image.json chromium-image.json firefox-image.json update-lock-file
all: image.json chromium-image.json firefox-image.json update-lock-file

# Necessary because multistage builds require a docker image name rather than a digest to be used
load-image-json: image.json
docker image tag $$(jq -r .imageID image.json) ${image_name}

chromium-image.json: load-image-json BrowserDockerfile
docker build --no-cache --progress=plain -f BrowserDockerfile --build-arg=BASE_IMAGE=${image_name} --build-arg=BROWSER=chromium -t chromium-${image_name} .
docker build -f BrowserDockerfile --build-arg=BASE_IMAGE=${image_name} --build-arg=BROWSER=chromium -t chromium-${image_name} .
docker image inspect chromium-${image_name} -f "{{.Id}}" | \
xargs -I {} echo "{\"imageID\": \"{}\"}" > $@

firefox-image.json: load-image-json BrowserDockerfile
docker build --no-cache --progress=plain -f BrowserDockerfile --build-arg=BASE_IMAGE=${image_name} --build-arg=BROWSER=firefox -t firefox-${image_name} .
docker build -f BrowserDockerfile --build-arg=BASE_IMAGE=${image_name} --build-arg=BROWSER=firefox -t firefox-${image_name} .
docker image inspect firefox-${image_name} -f "{{.Id}}" | \
xargs -I {} echo "{\"imageID\": \"{}\"}" > $@

Expand All @@ -25,8 +25,7 @@ update-lock-file: image.json
docker rm $$CONTAINER_ID

image.json:
echo $(CURDIR)
docker build --no-cache --progress=plain -t ${image_name} -f ./Dockerfile .
docker build -t ${image_name} -f ./Dockerfile .
docker image inspect ${image_name} -f "{{.Id}}" | \
xargs -I {} echo "{\"imageID\": \"{}\"}" > $@

Expand Down

0 comments on commit 6741822

Please sign in to comment.