fix(tcp): make TCP_NODELAY actually the default
#5764
+14
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nagle's algorithm is actually disabled by setting
TCP_NODELAYto true. In the current master, it is set to false, i.e. Nagle's algorithm is enabled.This PR sets
TCP_NODELAYper default totrueand fixes the description oftcp::Config::new.Fixes #4890.
Notes & open questions
Brought up by users in #5469 (comment) and #4916 (comment)
I also removed the
OptionaroundConfig.nodelaybecause even it in the current master it can never beNone. However, that means user's can never opt to just use the OS defaults.Change checklist
I have added tests that prove my fix is effective or that my feature works