fix(relay): Add resource limits to CircuitReq to be set
#5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhat1308 <[email protected]>
Signed-off-by: Prabhat1308 <[email protected]>
Rebase with new changes
Signed-off-by: Prabhat1308 <[email protected]>
MarcoPolo
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Looks good, and I'm pretty sure this fixes the issue after testing it with libp2p/test-plans#381.
I'll let @jxs merge this though.
MarcoPolo
changed the title
CircuitReq to be set CircuitReq to be set
jxs
reviewed
Jul 19, 2024
There was a problem hiding this comment.
LGTM Thanks! And thanks Marco for your review. @Prabhat1308 can you just run cargo fmt to address the lint failure?
Signed-off-by: Prabhat1308 <[email protected]>
Co-authored-by: João Oliveira <[email protected]>
jxs
approved these changes
Jul 19, 2024
TimTinkers
pushed a commit
to unattended-backpack/rust-libp2p
that referenced
this pull request
Sep 14, 2024
Fixes libp2p#5466 Adds resource limits to `CircuitReq` to be set . Pull-Request: libp2p#5493.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5466
Adds resource limits to
CircuitReqto be set .Change checklist