fix(kad): close progress whenever closer in range

[maqi]

Closer shall be calculated as closer to the seen num_results peers,
not just to be being the closest as current.

This is in parallel to the PR #4932
Split them into two to make the work easier to be discussed and reviewed.

Description

Notes & open questions

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[mergify]

This pull request has merge conflicts. Could you please resolve them @maqi? 🙏

[maqi]

This pull request has merge conflicts. Could you please resolve them @maqi? 🙏

PR is updated, sorry for the delay

[maqi]

Hi, @mxinden ,

here is the follow up fix in parallel to the PR #4932

let me know if it make sense.
thx

[mergify]

This pull request has merge conflicts. Could you please resolve them @maqi? 🙏

[guillaumemichel]

Thanks @maqi for looking into this, it is an important issue!

[maqi]

Hi, @guillaumemichel ,

Really appreciate your comments and suggestions.

Sorry for the late reply, have not check back this crate for a while as had been a while not receive any feedback.

Thx again and hope this PR could be merged soon.

Best Regards,

[maqi]

The failing clippy as at https://github.com/libp2p/rust-libp2p/actions/runs/8534098889/job/23377901550?pr=4934
seems not related to this PR ?

[guillaumemichel]

Looks good to me! Thanks for your contribution @maqi!