Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(identity): don't inherit rust-version from workspace #4866

Merged
merged 2 commits into from
Nov 28, 2023
Merged

chore(identity): don't inherit rust-version from workspace #4866

merged 2 commits into from
Nov 28, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

Another data point in favor of #4742 just popped up. With libp2p-identity being part of the workspace, we accidentally published a patch release that bumps the MSRV which is something we normally consider a breaking change.

This PR freezes the MSRV of libp2p-identity to avoid this problem in the future. Long-term, we should do #4742 to avoid these kind of mistakes instead of special-casing crates within the repository.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels Nov 14, 2023
@thomaseizinger thomaseizinger changed the title fix(identity): don't inherit rust-version for identity fix(identity): don't inherit rust-version from workspace Nov 14, 2023
@thomaseizinger thomaseizinger changed the title fix(identity): don't inherit rust-version from workspace chore(identity): don't inherit rust-version from workspace Nov 14, 2023
mxinden
mxinden approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, bummer. But I guess not a big deal for any users.

Looks good to me.

@thomaseizinger thomaseizinger added the internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. label Nov 28, 2023
@thomaseizinger thomaseizinger removed the internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. label Nov 28, 2023
@mergify mergify bot merged commit ee17df9 into master Nov 28, 2023
72 checks passed
@mergify mergify bot deleted the fix/identity-not-workspace-msrv branch November 28, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden