Skip to content

Commit

Permalink
Don't include webrtc into the tokio feature
Browse files Browse the repository at this point in the history
This works around a bug in cargo which unconditionally pulls the
dependencies even if the `webrtc` feature is not enabled and causes
issues in downstream with other conflicting dependencies.
  • Loading branch information
altonen committed Dec 4, 2023
1 parent 113bca9 commit faf496f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
6 changes: 6 additions & 0 deletions libp2p/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 0.51.4

- Don't include `webrtc` into `tokio` by default [PR 4962].

[PR 4962]: https://github.com/libp2p/rust-libp2p/pull/4962

## 0.51.3

- Deprecate the `mplex` feature.
Expand Down
4 changes: 2 additions & 2 deletions libp2p/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@ secp256k1 = ["libp2p-identity/secp256k1"]
serde = ["libp2p-core/serde", "libp2p-kad?/serde", "libp2p-gossipsub?/serde"]
tcp = ["dep:libp2p-tcp"]
tls = ["dep:libp2p-tls"]
tokio = ["libp2p-swarm/tokio", "libp2p-mdns?/tokio", "libp2p-tcp?/tokio", "libp2p-dns?/tokio", "libp2p-quic?/tokio", "libp2p-webrtc?/tokio"]
tokio = ["libp2p-swarm/tokio", "libp2p-mdns?/tokio", "libp2p-tcp?/tokio", "libp2p-dns?/tokio", "libp2p-quic?/tokio"]
uds = ["dep:libp2p-uds"]
wasm-bindgen = ["futures-timer/wasm-bindgen", "instant/wasm-bindgen", "getrandom/js", "libp2p-swarm/wasm-bindgen"]
wasm-ext = ["dep:libp2p-wasm-ext"]
wasm-ext-websocket = ["wasm-ext", "libp2p-wasm-ext?/websocket"]
webrtc = ["dep:libp2p-webrtc", "libp2p-webrtc?/pem"]
webrtc = ["dep:libp2p-webrtc", "libp2p-webrtc?/pem", "libp2p-webrtc/tokio"]
websocket = ["dep:libp2p-websocket"]
yamux = ["dep:libp2p-yamux"]

Expand Down

0 comments on commit faf496f

Please sign in to comment.