Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows 0.52 #34

Merged
merged 3 commits into from
Nov 12, 2024
Merged

windows 0.52 #34

merged 3 commits into from
Nov 12, 2024

Conversation

kayabaNerve
Copy link
Contributor

No description provided.

@kayabaNerve
Copy link
Contributor Author

kayabaNerve commented Dec 5, 2023

Error: Path `"/home/runner/work/if-watch/if-watch/target/armv7-linux-androideabi/debug/examples/libif_watch.so"` doesn't exist.

I don't believe this CI failure is my fault. Possibly a side effect of not having a Cargo.lock committed?

@mxinden
Copy link
Member

mxinden commented Mar 12, 2024

Sorry for the late reply here.

I don't seem to be able to trigger CI again given the last run being so old.. Mind pushing an empty commit?

@kayabaNerve
Copy link
Contributor Author

I'd be happy to update this with a range version of the prior windows and latest windows (now 0.54).

Re: my prior note about not having a Cargo.lock... I'm not entirely sure why I posited that. Possibly the semi-recent changes to the cc crate? Some similar issue I found while trying to debug this?

@kayabaNerve
Copy link
Contributor Author

windows 0.54 does have a breaking change to the relevant API. Accordingly, while the committed range statement works, upgrading to windows 0.54 would be distinct.

Practically, I generally try to keep everything on the latest versions so when the laggards do update, everything is tidy. I don't like holding back modern crates for old versions. This range statement is the best of both worlds in that regard (no duplication due to laggards, latest version once laggards update), so long as it covers the latest version.

With that personal policy in mind, I'd be happy to submit a commit for 0.54, yet I'm unsure I have the personal motivation to make the rounds again at this time. With tokio remaining on 0.51 for a bit longer, and my prior effort being to get updates to 0.52 (which still is going through the process of being merged to all my dependencies)...

Let me know if you'd like me to make this a 0.54 PR or if this is preferable for now and I should come back in a few months (whenever I have the motivation to make the rounds) with the 0.54 PR.

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Let me know if you'd like me to make this a 0.54 PR or if this is preferable for now and I should come back in a few months (whenever I have the motivation to make the rounds) with the 0.54 PR.

That would be nice yeah! 🚀

@jxs jxs merged commit d7025a1 into libp2p:master Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants