Skip to content

Commit

Permalink
scsi: Declare local symbols static
Browse files Browse the repository at this point in the history
Avoid that building with W=1 causes gcc to report warnings about symbols
that have not been declared.

Cc: Hannes Reinecke <[email protected]>
Signed-off-by: Bart Van Assche <[email protected]>
Reviewed-by: Hannes Reinicke <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Reviewed-by: Ewan Milne <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
  • Loading branch information
Bart Van Assche authored and martinkpetersen committed Mar 30, 2016
1 parent ea76543 commit d78540d
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/scsi/scsi_sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ const char *scsi_host_state_name(enum scsi_host_state state)
return name;
}

#ifdef CONFIG_SCSI_DH
static const struct {
unsigned char value;
char *name;
Expand All @@ -94,7 +95,7 @@ static const struct {
{ SCSI_ACCESS_STATE_TRANSITIONING, "transitioning" },
};

const char *scsi_access_state_name(unsigned char state)
static const char *scsi_access_state_name(unsigned char state)
{
int i;
char *name = NULL;
Expand All @@ -107,6 +108,7 @@ const char *scsi_access_state_name(unsigned char state)
}
return name;
}
#endif

static int check_set(unsigned long long *val, char *src)
{
Expand Down Expand Up @@ -226,7 +228,7 @@ show_shost_state(struct device *dev, struct device_attribute *attr, char *buf)
}

/* DEVICE_ATTR(state) clashes with dev_attr_state for sdev */
struct device_attribute dev_attr_hstate =
static struct device_attribute dev_attr_hstate =
__ATTR(state, S_IRUGO | S_IWUSR, show_shost_state, store_shost_state);

static ssize_t
Expand Down Expand Up @@ -401,7 +403,7 @@ static struct attribute *scsi_sysfs_shost_attrs[] = {
NULL
};

struct attribute_group scsi_shost_attr_group = {
static struct attribute_group scsi_shost_attr_group = {
.attrs = scsi_sysfs_shost_attrs,
};

Expand Down

0 comments on commit d78540d

Please sign in to comment.