Deprecated vebosity #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9il
reviewed
Oct 10, 2016
| @@ -133,7 +134,8 @@ Params: | |||
| Returns: | |||
| Returns normalized input tensor. | |||
| */ | |||
| deprecated @nogc nothrow auto normalized(Range, size_t N)(auto ref Slice!(N, Range) tensor, NormType normType = NormType.L2) | |||
| deprecated("Use array based division: tensor[] /= norm, or mir.ndslice.algorithm: tensor.ndEach!(v => v /= norm)") | |||
| @@ -168,7 +170,8 @@ Returns: | |||
| Scaled input tensor. | |||
|
|
|||
| */ | |||
| deprecated @nogc nothrow auto scaled(Scalar, Range, size_t N)(auto ref Slice!(N, Range) tensor, Scalar alpha = 1, Scalar beta = 0) | |||
| deprecated("Function will be moved to Mir") | |||
| @nogc nothrow auto scaled(Scalar, Range, size_t N)(auto ref Slice!(N, Range) tensor, Scalar alpha = 1, Scalar beta = 0) | |||
There was a problem hiding this comment.
Let's do not deprecate what is not in already in Mir
| @@ -196,6 +199,7 @@ Params: | |||
| maxValue = Maximal value output tensor should contain. | |||
|
|
|||
| */ | |||
| deprecated("Function will be moved to Mir") | |||
|
Awesome! Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added deprecation messages as suggested in #61. Also deprecated
dcv.core.algorithm.ranged, as suggested in #44. With norm and asType deprecated, should be good to close #35.@9il, could you check those messages and tell if you think those should be formatted differently? And if you agree, I would like to close those 3 issues with this PR.