Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore to remove *.cmake #1209

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Update .gitignore to remove *.cmake #1209

merged 1 commit into from
Dec 22, 2024

Conversation

ianhbell
Copy link
Contributor

I am building a package that includes geos as a dependency, with compilation targeting Python, and builds happening with scikit-build-core. I had a mysterious build failure for missing files in the cmake folder inside the build folder when built with pipx run build, and tracked down the problem to the fact that the build runs a git clean and doesn't copy over files that are ignored by .gitignore. Fixing that (as in this PR), allowed that part of the build to work properly. I think this change is harmless since there are already .cmake files in the repo so they should probably not be in the .gitignore anyhow.

@dbaston
Copy link
Member

dbaston commented Dec 20, 2024

I think this change is harmless since there are already .cmake files in the repo so they should probably not be in the .gitignore anyhow.

I see this was initially added in dd1be73 to support in-tree builds. I'm OK with the proposed change - I feel like the expectation is that if you do an in-tree build, you're going to end up with bunch of garbage in your tree, and the solution is to not build in your tree.

@ianhbell
Copy link
Contributor Author

I think this change is harmless since there are already .cmake files in the repo so they should probably not be in the .gitignore anyhow.

I see this was initially added in dd1be73 to support in-tree builds. I'm OK with the proposed change - I feel like the expectation is that if you do an in-tree build, you're going to end up with bunch of garbage in your tree, and the solution is to not build in your tree.

Yeah, out-of-source is just so much cleaner, thanks for the context

Copy link
Contributor

@mwtoews mwtoews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dbaston for the context of the change. In-source builds are not a normal method of building, so this item shouldn't be here. For reference, recommended .gitignore items for CMake projects is here.

And thanks again @ianhbell for the helpful PR!

@mwtoews mwtoews merged commit e1c9a7c into libgeos:main Dec 22, 2024
28 checks passed
@ianhbell ianhbell deleted the patch-1 branch December 23, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants