Update .gitignore to remove *.cmake #1209
Merged
+0
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am building a package that includes geos as a dependency, with compilation targeting Python, and builds happening with
scikit-build-core
. I had a mysterious build failure for missing files in thecmake
folder inside the build folder when built withpipx run build
, and tracked down the problem to the fact that the build runs a git clean and doesn't copy over files that are ignored by.gitignore
. Fixing that (as in this PR), allowed that part of the build to work properly. I think this change is harmless since there are already.cmake
files in the repo so they should probably not be in the.gitignore
anyhow.