feat: add DBStructure schema #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasamuku
force-pushed
the
add_db_structure_schema
branch
from
cec3f3d to
2533272
Compare
sasamuku
requested review from
hoshinotsuyoshi,
FunamaYukina,
junkisai and
MH4GF
and removed request for
a team
hoshinotsuyoshi
approved these changes
Nov 13, 2024
| @@ -1,9 +1,51 @@ | |||
| import * as v from 'valibot' | |||
|
|
|||
| const tablesSchema = v.object({}) | |||
| const fieldSchema = v.object({ | |||
MH4GF
reviewed
Nov 14, 2024
sasamuku
force-pushed
the
add_db_structure_schema
branch
from
2533272 to
9d85a7d
Compare
MH4GF
approved these changes
Nov 14, 2024
| deleteConstraint: v.string(), | ||
| }) | ||
|
|
||
| const tablesSchema = v.record(v.string(), tableSchema) // Key is table name |
There was a problem hiding this comment.
nits: If you are going to make comments like this, it is better to use the type alias practice:
Suggested change
| const tablesSchema = v.record(v.string(), tableSchema) // Key is table name | |
| const tableNameSchema = v.string() | |
| const tablesSchema = v.record(tableNameSchema, tableSchema) |
Of course, it is also used for startTableName, etc.
Improves readability by providing a link between which values are referenced and where.
There was a problem hiding this comment.
Thanks, added type alias:
6cde75d
hoshinotsuyoshi
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an experimental schema and is likely to change in the near future.
As a first step, referencing drawDB, which offers functionality similar to our service.
https://github.com/drawdb-io/drawdb/blob/main/src/data/schemas.js
Related Issue
Changes
Testing
Other Information
Please note that some drawDB schemas have been removed for minimal start.