Enhance Frontend CI with Testing

[hoshinotsuyoshi]

Summary

This pull request enhances the frontend CI setup by adding automated testing, improves the CLI structure, and updates package dependencies for better functionality. It ensures the liam CLI commands are organized and streamlined, with vitest introduced for testing.

Related Issue

N/A

Changes

1. Workflow Updates: Added a new frontend-ci job in the GitHub Actions workflow for running tests only when there are changes detected by the setup-job. This job includes steps to set up the environment and execute pnpm test:turbo.
2. CLI Refactor: Simplified cli.ts to import the program from a new src/index.js, removing redundant code and centralizing CLI logic.
3. Command Implementations: Added buildCommand, devCommand, and previewCommand modules to encapsulate their respective logic, improving readability and maintainability.
4. Testing Setup: Introduced vitest as the testing framework and added test files for runPreprocess and the CLI commands to validate functionality.
5. Package Updates: Updated package.json to include vitest and added a test script for running the tests. Modified turbo.json to incorporate the test task configuration.

• 86a3fd3 : Refactor CLI to modularize commands
• a2fa9c5 : $ pnpm add -D vitest @types/node
• 805f42c : Add testing setup with Vitest and initial tests for CLI
• 8c43185 : Add CI workflow for frontend testing with Turbo

Testing

Same as #79 ✔️

[junkisai]

LGTM!
I think adopting Vitest is a great idea!

[junkisai]

[nits]
Could we write it like this to make it more concise?

Suggested change

	import { runPreprocess } from '../runPreprocess.js'
	import { runPreprocess } from '../runPreprocess'

[junkisai]

[nits]
Could we write it like this to make it more concise?

Suggested change

	import { buildCommand } from './buildCommand.js'
	import { devCommand } from './devCommand.js'
	import { previewCommand } from './previewCommand.js'
	export { buildCommand, devCommand, previewCommand }
	export { buildCommand } from './buildCommand'
	export { devCommand } from './devCommand'
	export { previewCommand } from './previewCommand'

[hoshinotsuyoshi]

That's actually been a bit of a headache for me since yesterday! At the moment, removing the .js extension causes the CLI to not work correctly. 😭 😭

error

[cli]$ rm -rf dist dist-cli/ node_modules/.tmp

[cli]$ pnpm run build:cli

> @liam/[email protected] build:cli /Users/hoshino/.local/share/go/src/github.com/liam-hq/liam/frontend/packages/cli
> tsc -p tsconfig.node.json

[cli]$
[cli]$ pnpm link --global

[cli]$ which liam
/Users/hoshino/.local/share/pnpm/liam

[cli]$ liam erd help
node:internal/modules/esm/resolve:265
    throw new ERR_MODULE_NOT_FOUND(
          ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/hoshino/.local/share/go/src/github.com/liam-hq/liam/frontend/packages/cli/dist-cli/src/cli/commands/buildCommand' imported from /Users/hoshino/.local/share/go/src/github.com/liam-hq/liam/frontend/packages/cli/dist-cli/src/cli/commands/index.js
    at finalizeResolution (node:internal/modules/esm/resolve:265:11)
    at moduleResolve (node:internal/modules/esm/resolve:933:10)
    at defaultResolve (node:internal/modules/esm/resolve:1157:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:390:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:359:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:234:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:87:39)
    at link (node:internal/modules/esm/module_job:86:36) {
  code: 'ERR_MODULE_NOT_FOUND',
  url: 'file:///Users/hoshino/.local/share/go/src/github.com/liam-hq/liam/frontend/packages/cli/dist-cli/src/cli/commands/buildCommand'
}

Node.js v20.12.0

So, I can only confirm that it functions properly in its current state, with the .js extension included. It’s not ideal, but it's a workaround that keeps things running for now.

To explain a bit further, if I change tsconfig.node.json from "module": "ESNext" to "CommonJS" and remove "type": "module" from package.json, the CLI would indeed work without the .js extension. However, doing so triggers a warning: The CJS build of Vite's Node API is deprecated. See https://vite.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.

I’m hoping to get some help with this issue from someone else in the future. Also, since this is a rather fragile part of the setup, I’m considering adding a smoke test to ensure the CLI continues to work properly.

Hope that gives some clarity, and thank you for the suggestion!