setup @liam/cli package #73
Conversation
| // https://vite.dev/config/ | ||
| export default defineConfig({ | ||
| plugins: [react()], | ||
| }) |
There was a problem hiding this comment.
📝 Currently, assets can be built using vite with just this setting, but the following additional actions are required
- Make it executable as CLI and accept SQL files as input
- Convert SQL files to DBStructure and pass them to
ERDRendererReact components - (Publish as npm package)
There was a problem hiding this comment.
@hoshinotsuyoshi I would like to request this research!
| import { ERDRenderer } from '@liam/erd-core' | ||
|
|
||
| function App() { | ||
| return <ERDRenderer /> |
There was a problem hiding this comment.
📝 Proceed with React Flow implementation with this component.
MH4GF
requested review from
hoshinotsuyoshi,
FunamaYukina,
junkisai and
sasamuku
and removed request for
a team
| @@ -0,0 +1,29 @@ | |||
| { | |||
| "name": "@liam/cli", | |||
There was a problem hiding this comment.
nits: Should we discuss whether @liam/ (scope) is the appropriate choice? In any case, I think it won’t be difficult to change this later. :)
There was a problem hiding this comment.
This is correct, the scope needs to be considered!
There may be issues such as whether the npm organization can be reserved. I would like to discuss this later.
| "allowImportingTsExtensions": true, | ||
| "isolatedModules": true, | ||
| "moduleDetection": "force", | ||
| "noEmit": true, |
There was a problem hiding this comment.
nits:
In cli/tsconfig.node.json, should noEmit be set to false?
I thought the CLI would be provided as a .js file.
In any case, I’ll look into it on my end and make any necessary changes later if there are issues.
There was a problem hiding this comment.
That's right, I would need a js file to provide it as a CLI!
|
thanks for reviews! |
Created a package skeleton to satisfy the “run as CLI and output HTML” use case