Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add NavPrevPost, NavNextPost #45

Merged
merged 6 commits into from
Oct 16, 2024
Merged

feat: Add NavPrevPost, NavNextPost #45

merged 6 commits into from
Oct 16, 2024

Conversation

junkisai
Copy link
Member

@junkisai junkisai commented Oct 15, 2024 •
edited
Loading

Summary

Here's a summary of the changes:

  1. Added NavPrevPost and NavNextPost components.
  2. Created a new utility function for generating links to article details.
mobile pc
スクリーンショット 2024-10-16 16 03 53 スクリーンショット 2024-10-16 16 04 04

Related Issue

Changes

Testing

Other Information

@junkisai junkisai temporarily deployed to preview - service-site October 15, 2024 11:39 — with GitHub Actions Inactive
@junkisai junkisai temporarily deployed to preview - service-site-storybook October 15, 2024 11:39 — with GitHub Actions Inactive
@junkisai junkisai force-pushed the feat/nav-post-component branch from 567ceb7 to 13fcba2 Compare October 16, 2024 07:03
@junkisai junkisai temporarily deployed to preview - service-site October 16, 2024 07:04 — with GitHub Actions Inactive
@junkisai junkisai temporarily deployed to preview - service-site-storybook October 16, 2024 07:04 — with GitHub Actions Inactive
@junkisai junkisai changed the title Feat/nav post component feat: Add NavPrevPost, NavNextPost Oct 16, 2024
@junkisai junkisai temporarily deployed to preview - service-site October 16, 2024 07:20 — with GitHub Actions Inactive
@junkisai junkisai temporarily deployed to preview - service-site-storybook October 16, 2024 07:20 — with GitHub Actions Inactive
@junkisai junkisai force-pushed the feat/nav-post-component branch from 7433b20 to 42328aa Compare October 16, 2024 07:27
@junkisai junkisai temporarily deployed to preview - service-site October 16, 2024 07:27 — with GitHub Actions Inactive
@junkisai junkisai temporarily deployed to preview - service-site-storybook October 16, 2024 07:27 — with GitHub Actions Inactive
@junkisai junkisai marked this pull request as ready for review October 16, 2024 07:30
@junkisai junkisai requested a review from a team as a code owner October 16, 2024 07:30
@junkisai junkisai requested review from hoshinotsuyoshi, FunamaYukina, MH4GF and sasamuku and removed request for a team October 16, 2024 07:30
MH4GF
MH4GF approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 😄

@junkisai junkisai added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 74a7853 Oct 16, 2024
8 checks passed
@junkisai junkisai deleted the feat/nav-post-component branch October 16, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MH4GF MH4GF MH4GF approved these changes

@hoshinotsuyoshi hoshinotsuyoshi Awaiting requested review from hoshinotsuyoshi hoshinotsuyoshi was automatically assigned from route06inc/liam-dev

@FunamaYukina FunamaYukina Awaiting requested review from FunamaYukina FunamaYukina was automatically assigned from route06inc/liam-dev

@sasamuku sasamuku Awaiting requested review from sasamuku sasamuku was automatically assigned from route06inc/liam-dev

Assignees

@junkisai junkisai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junkisai @MH4GF