maintenance: generate CSS Variables from Figma Variables #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MH4GF
temporarily deployed
to
preview - service-site
GitHub Actions
Inactive
MH4GF
temporarily deployed
to
preview - service-site-storybook
GitHub Actions
Inactive
MH4GF
force-pushed
the
figma-to-css-variables
branch
from
eb1dfd5 to
f0daaee
Compare
MH4GF
temporarily deployed
to
preview - service-site
GitHub Actions
Inactive
MH4GF
temporarily deployed
to
preview - service-site-storybook
GitHub Actions
Inactive
MH4GF
force-pushed
the
figma-to-css-variables
branch
from
f0daaee to
4a996b5
Compare
MH4GF
temporarily deployed
to
preview - service-site
GitHub Actions
Inactive
MH4GF
temporarily deployed
to
preview - service-site-storybook
GitHub Actions
Inactive
MH4GF
commented
Oct 15, 2024
| @import './variables.tokens-dark.css'; | ||
| @import './variables.tokens-typography.css'; | ||
| @import './Dark/variables.css'; | ||
| @import './Mode 1/variables.css'; |
There was a problem hiding this comment.
💭 Collection name? Mode name? I'd like to change it at just the right time.
MH4GF
commented
Oct 15, 2024
There was a problem hiding this comment.
Please keep the review of the script section small, as it should work for now!
MH4GF
requested review from
hoshinotsuyoshi,
FunamaYukina,
junkisai and
sasamuku
and removed request for
a team
MH4GF
commented
Oct 15, 2024
| To run the script, use the following command: | ||
|
|
||
| ```sh | ||
| FIGMA_FILE_KEY=FnK... FIGMA_ACCESS_TOKEN=figd_xxx pnpm --filter @packages/figma-to-css-variables gen --output '../../apps/service-site/src/styles' --filter-modes 'Dark,Mode 1' |
There was a problem hiding this comment.
You can also run this to run it in your hand 🙆🏻♂️
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scratch implemented CSS Variables generation script.
I really wanted to check the behavior by having no differences in the generated files, but this was not possible because the order of the variables would have changed.
I am looking at the Preview environment and making sure there are no changes.
Notice
The next PR will enable GitHub Actions to do this.