feat: implement ShareDropdownMenu #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MH4GF
temporarily deployed
to
preview - service-site
GitHub Actions
Inactive
MH4GF
temporarily deployed
to
preview - service-site-storybook
GitHub Actions
Inactive
MH4GF
temporarily deployed
to
preview - service-site
GitHub Actions
Inactive
MH4GF
temporarily deployed
to
preview - service-site-storybook
GitHub Actions
Inactive
MH4GF
changed the title
MH4GF
commented
Oct 11, 2024
frontend/apps/service-site/src/features/posts/components/ShareDropdownMenu/CopyLinkItem.tsx
Show resolved
Hide resolved
MH4GF
commented
Oct 11, 2024
| > | ||
| <span>{t('posts.share.facebook')}</span> | ||
| </DropdownMenuItem> | ||
| <DropdownMenuItem | ||
| leftIcon={<LinkedInIcon className={styles.icon} />} | ||
| onSelect={() => alert('Item 3 clicked')} | ||
| onSelect={handleSelect( | ||
| `https://www.linkedin.com/sharing/share-offsite/?url=${url}`, |
There was a problem hiding this comment.
It seems that if the page returns 200 statuses, as in this URL, it can be shared without any problem.
https://www.linkedin.com/sharing/share-offsite/?url=https://route06.co.jp
MH4GF
requested review from
hoshinotsuyoshi,
FunamaYukina,
junkisai and
sasamuku
and removed request for
a team
...tend/apps/service-site/src/features/posts/components/ShareDropdownMenu/ShareDropdownMenu.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: hoshino tsuyoshi <[email protected]>
MH4GF
temporarily deployed
to
preview - service-site
GitHub Actions
Inactive
MH4GF
temporarily deployed
to
preview - service-site-storybook
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share URLs for each SNS were implemented.
2024-10-11.18.20.23.mov
NOTE: linkedin seems to be an error for 401 pages.